[FIX] Corpus: remove text features which not in metas #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
==========================================
+ Coverage 85.37% 85.38% +<.01%
==========================================
Files 34 34
Lines 1860 1861 +1
Branches 335 336 +1
==========================================
+ Hits 1588 1589 +1
Misses 237 237
Partials 35 35 |
nikicc
suggested changes
Nov 9, 2017
orangecontrib/text/corpus.py
Outdated
| @@ -434,8 +434,7 @@ def retain_preprocessing(orig, new, key=...): | |||
| else: | |||
| raise TypeError('Indexing by type {} not supported.'.format(type(key))) | |||
| new._dictionary = orig._dictionary | |||
|
|
|||
| new.text_features = orig.text_features | |||
| new.text_features = list(set(orig.text_features) & set(new.domain.metas)) or None | |||
There was a problem hiding this comment.
Why or None? Perhaps it's safer to set text_features to an empty list.
There was a problem hiding this comment.
Perhaps also fix this in __init__?
There was a problem hiding this comment.
self.text_features = None changed to self.text_features = []
text_features=None as a default argument in __init__ is kept.
| domain = Domain(attributes=c.domain.attributes, class_vars=c.domain.class_vars) | ||
| d = c.transform(domain) | ||
| self.assertTrue(d.text_features is None or d.text_features[0] in d.domain.metas) | ||
| self.assertTrue(d.text_features is None or d.text_features[0] in d.domain.metas) |
There was a problem hiding this comment.
Isn't this the same as above line?
| c = Corpus.from_file('friends-transcripts') | ||
| domain = Domain(attributes=c.domain.attributes, class_vars=c.domain.class_vars) | ||
| d = c.transform(domain) | ||
| self.assertTrue(d.text_features is None or d.text_features[0] in d.domain.metas) |
There was a problem hiding this comment.
Could we make thi check without an or.
| d = c.transform(domain) | ||
| self.assertTrue(d.text_features is None or d.text_features[0] in d.domain.metas) | ||
| self.assertTrue(d.text_features is None or d.text_features[0] in d.domain.metas) | ||
| d.copy() |
There was a problem hiding this comment.
Should we add a comment here?
| GH-324 | ||
| GH-325 | ||
| """ | ||
| c = Corpus.from_file('friends-transcripts') |
There was a problem hiding this comment.
Perhaps, use deerwester that loads much faster?
nikicc
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #324
Description of changes
Includes