[FIX] Corpus: X and Y arrays must always be float! #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #330 +/- ##
=======================================
Coverage 84.92% 84.92%
=======================================
Files 33 33
Lines 1864 1864
Branches 336 336
=======================================
Hits 1583 1583
Misses 242 242
Partials 39 39 |
|
@jerneju where do ints cause problems? Also, do you think we should solve this in the |
|
@nikicc : Connect Twitter and Scatter Plot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Sometimes a
corpusis created which has integer types numpy arrays.See here:
Description of changes
Make sure that a new created array is type
float64.Includes