owpreprocess: Add choice in FilteringModule for All Files (*) #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FileWidget used in the FilteringModule class of owpreprocess only allows opening files with a .txt extension. The stopwords files included with the nltk_data do not have this extension. This change adds a selector for "All Files (*)" in addition to "Only text files (*.txt)" in the FileWidget.
|
Excellent in all respects! The Travis error, I'll wager, is unrelated. Merging. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The FileWidget used in the FilteringModule class of owpreprocess allows opening files with a .txt extension only. The stopwords files included with the nltk_data do not have this extension. So these files nor any other files lacking a .txt extension can be selected as files for Stopwords or Lexicons.
Fixes #333.
Description of changes
This change adds a selector for "All files" in addition to "Only text files" in the FileWidget creation for the FilteringModule class.
The documentation describes creating files from scratch with a .txt extension, which is still appropriate, so no documentation changes are needed. No tests cover the FileWidget dialogs used by the FilteringModule.
Includes