[FIX] guardian: fix failing tests #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 85.2% 85.21% +<.01%
==========================================
Files 33 33
Lines 1866 1867 +1
Branches 336 336
==========================================
+ Hits 1590 1591 +1
Misses 237 237
Partials 39 39 |
|
Still not working. 😞 Any ideas? |
|
Nah, The Guardian is now fine. |
|
Nope, I have restarted tests twice and they still fail with the same error: #357 |
|
Yes, it's really strange because if I run Travis on my fork it works every time, but on the main repo, it dosesn't. This needs further investigation. |
Beside restarting, you need to rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #354
Description of changes
The
testkey has a limit we exceeded so the tests failed. This is resolved by requesting a developer API key. Because it's a secret we add it to Travis as an environment variable (THE_GUARDIAN_API_KEY).Includes