Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guardian request limit exceeded #365

Merged
merged 3 commits into from
Aug 2, 2018

Conversation

robertcv
Copy link
Collaborator

@robertcv robertcv commented Aug 1, 2018

Issue

TheGuardianAPI would crash if requests limit is exceeded. The exception was not informative because it's raised further in the request processing.

Description of changes

Now an informative exception is raised. Additionally, this helps with the falling test which is now skipped if this error is raised.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

codecov-io commented Aug 1, 2018

Codecov Report

Merging #365 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
+ Coverage   85.21%   85.24%   +0.03%     
==========================================
  Files          33       33              
  Lines        1867     1871       +4     
  Branches      336      337       +1     
==========================================
+ Hits         1591     1595       +4     
  Misses        237      237              
  Partials       39       39

@PrimozGodec
Copy link
Collaborator

The code looks ok for me. Can you try to cover the case when API limit exceed with the unit-test if that is possible?

@ajdapretnar
Copy link
Collaborator

Codecov still not happy. Parts of code aren't covered with tests. @robertcv do you think that's something we should add or let it be?

@robertcv robertcv force-pushed the fixes/guardian_limit branch from 4ab1e6e to e70b824 Compare August 2, 2018 06:45
@robertcv
Copy link
Collaborator Author

robertcv commented Aug 2, 2018

@ajdapretnar I add a test with mocked request data

@ajdapretnar ajdapretnar merged commit 5340e0d into biolab:master Aug 2, 2018
@robertcv robertcv deleted the fixes/guardian_limit branch November 19, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants