-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output corresponding duplicate cluster #379
Conversation
Looks good, could you just add a new line on the end of the test. |
We discussed with @lanzagar to solve this in a nicer way. |
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
- Coverage 85.44% 85.08% -0.36%
==========================================
Files 34 34
Lines 1951 1951
Branches 344 344
==========================================
- Hits 1667 1660 -7
- Misses 243 247 +4
- Partials 41 44 +3 |
9c4e12e
to
b40ffab
Compare
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
=======================================
Coverage 85.21% 85.21%
=======================================
Files 34 34
Lines 1962 1962
Branches 344 344
=======================================
Hits 1672 1672
Misses 250 250
Partials 40 40 |
@robertcv this is ready for another review and potential merge. |
I produced an error by deselecting the selected cluster in Duplicate Cluster widget. This needs to be handled before I merge. |
b40ffab
to
1886ecb
Compare
Fixed. I also added a test to prevent future errors. :) 💪 |
Issue
Fixes #378.
Description of changes
Detect Duplicates now outputs correct documents with Duplicate Cluster output.
Includes