Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output corresponding duplicate cluster #379

Merged
merged 2 commits into from
Nov 30, 2018

Conversation

ajdapretnar
Copy link
Collaborator

Issue

Fixes #378.

Description of changes

Detect Duplicates now outputs correct documents with Duplicate Cluster output.

Includes
  • Code changes
  • Tests
  • Documentation

@robertcv
Copy link
Collaborator

Looks good, could you just add a new line on the end of the test.

@ajdapretnar
Copy link
Collaborator Author

We discussed with @lanzagar to solve this in a nicer way. int(cluster[1:]) is really not all that elegant and not very future-proof. I need to figure out how to retrieve just the cluster number and not cast strings to ints. Suggestions welcome. I honestly think this widget should be re-done in parts as some instances are duplicated. I would be nice if we can work with a simple dict and use it for everything.

@codecov-io
Copy link

Codecov Report

Merging #379 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   85.44%   85.08%   -0.36%     
==========================================
  Files          34       34              
  Lines        1951     1951              
  Branches      344      344              
==========================================
- Hits         1667     1660       -7     
- Misses        243      247       +4     
- Partials       41       44       +3

@codecov-io
Copy link

codecov-io commented Nov 28, 2018

Codecov Report

Merging #379 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   85.21%   85.21%           
=======================================
  Files          34       34           
  Lines        1962     1962           
  Branches      344      344           
=======================================
  Hits         1672     1672           
  Misses        250      250           
  Partials       40       40

@ajdapretnar
Copy link
Collaborator Author

@robertcv this is ready for another review and potential merge.

@robertcv
Copy link
Collaborator

I produced an error by deselecting the selected cluster in Duplicate Cluster widget. This needs to be handled before I merge.

@ajdapretnar
Copy link
Collaborator Author

Fixed. I also added a test to prevent future errors. :) 💪

@robertcv robertcv merged commit 5ada434 into biolab:master Nov 30, 2018
@ajdapretnar ajdapretnar deleted the duplicate-fix branch January 21, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants