Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] OWWordCloud: scale visualization #381

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

robertcv
Copy link
Collaborator

Issue

Fixes #347

Description of changes

Scale font size in proportion to the window size.

Includes
  • Code changes
  • Tests
  • Documentation

@robertcv
Copy link
Collaborator Author

@ajdapretnar Could you please check if the visualizations looks ok. Perhaps we could find a better scaling factor.

@codecov-io
Copy link

Codecov Report

Merging #381 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
- Coverage   85.44%   85.08%   -0.36%     
==========================================
  Files          34       34              
  Lines        1951     1951              
  Branches      344      344              
==========================================
- Hits         1667     1660       -7     
- Misses        243      247       +4     
- Partials       41       44       +3

@ajdapretnar
Copy link
Collaborator

I like it. The only thing that could be fixed as well is all the redundant white space around the cloud. I think it is excessive. Can you make it smaller? This way the scaling would look better, too.

@robertcv
Copy link
Collaborator Author

The problem is that it depends on the number of displayed words. Some clouds are smaller some are bigger.

@ajdapretnar
Copy link
Collaborator

Hm. I get redundant white space for all corpora... 🤔 It's not such a big deal, but if you have any idea how to get rid of so much white space, it'd be great. If not, I can merge as it is.

screen shot 2018-10-29 at 12 17 13

screen shot 2018-10-29 at 12 17 18

@ajdapretnar
Copy link
Collaborator

Oh, perhaps this could be a part of this issue as well, since scaling depends on the window size. I don't like the fact that one can shrink the widget all the way to the control area. Perhaps some minimum size is in order here. I'll let you decide on this one. :)

@ajdapretnar ajdapretnar changed the title [WIP][FIX] OWWordCloud: scale visualization [FIX] OWWordCloud: scale visualization Nov 13, 2018
@ajdapretnar ajdapretnar merged commit 60d30bd into biolab:master Nov 13, 2018
@robertcv robertcv deleted the fixes/word_cloud_size branch November 19, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants