Fix PyQt version to 5.11 #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
reviewed
Feb 18, 2019
.travis.yml
Outdated
| @@ -37,7 +37,7 @@ before_install: | |||
|
|
|||
| install: | |||
| - travis_wait pip install -r requirements.txt | |||
| - source $TRAVIS_BUILD_DIR/.travis/install_pyqt.sh | |||
| - pip install sip pyqt5==5.11 | |||
There was a problem hiding this comment.
I think pyqt5==5.11.* should fix it
ajdapretnar
force-pushed
the
fix-pyqt-version
branch
from
e4d6cdf to
ab36024
Compare
|
Tests fail because of some gensim change I reckon. I have a hard time debugging this, but I will try. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Attempt at fixing the failing Travis tests.
Description of changes
Fix PyQt to 5.11.
Includes