Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] topics: HdpModel showing no topics #413

Merged
merged 2 commits into from
Feb 19, 2019

Conversation

robertcv
Copy link
Collaborator

@robertcv robertcv commented Feb 19, 2019

Issue

Fixes #411
gensim>=3.7.0 changed HdpModel.show_topics() behavior when using num_topics=-1 (issue)

Description of changes

Replace -1 with number of topics.

Includes
  • Code changes
  • Tests
  • Documentation

@ajdapretnar
Copy link
Collaborator

Could you perhaps add the reference to the question you posted on Gensim? So we can keep track of it.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@d8f7afc). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #413   +/-   ##
=========================================
  Coverage          ?   85.88%           
=========================================
  Files             ?       34           
  Lines             ?     1963           
  Branches          ?      344           
=========================================
  Hits              ?     1686           
  Misses            ?      237           
  Partials          ?       40

@ajdapretnar ajdapretnar merged commit 9572916 into biolab:master Feb 19, 2019
@robertcv robertcv deleted the fix/topic_modeling branch November 19, 2019 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants