[WIP] Replace local FDR with Orange's #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajdapretnar
changed the title
|
I'd like to write tests, but have to figure out how to call settings. |
3 tasks
|
@janezd I'd love to finish this, but I don't know how to test with settings. Would appreciate help. :) |
ajdapretnar
force-pushed
the
FRD-from-core
branch
from
09c4922 to
83ab92e
Compare
|
Travis probably requires the latest version of Orange for tests to pass. I wonder whether we should fix Orange version in here as well. |
ajdapretnar
force-pushed
the
FRD-from-core
branch
from
83ab92e to
3a8a464
Compare
ajdapretnar
force-pushed
the
FRD-from-core
branch
from
3a8a464 to
27cd416
Compare
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
+ Coverage 85.88% 86.06% +0.18%
==========================================
Files 34 34
Lines 1963 1931 -32
Branches 344 331 -13
==========================================
- Hits 1686 1662 -24
+ Misses 236 229 -7
+ Partials 41 40 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Replace local implementation of FDR with core Orange's implementation.
Description of changes
Import FDR from Orange.
Includes