Remove validate email #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
==========================================
- Coverage 85.59% 85.57% -0.03%
==========================================
Files 34 34
Lines 1937 1934 -3
Branches 331 330 -1
==========================================
- Hits 1658 1655 -3
Misses 239 239
Partials 40 40 |
PrimozGodec
force-pushed
the
remove-validate_email
branch
2 times, most recently
from
486497b to
07de368
Compare
|
A comment here. When opening the email window, a warning should appear after the users types something and presses enter. I don't like being greeted by an error when I haven't even done anything. Also, I think it would be nice to have focus on the text line. |
PrimozGodec
force-pushed
the
remove-validate_email
branch
from
07de368 to
075761b
Compare
|
@ajdapretnar I agree with you. I have addressed the issues. :) |
PrimozGodec
force-pushed
the
remove-validate_email
branch
from
075761b to
fd0c256
Compare
|
@ajdapretnar tests are passing now. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #440
Description of changes
With this pull request we:
Includes