Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with split canvas #445

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Conversation

ajdapretnar
Copy link
Collaborator

Issue

Current merging of biolab/orange3#3772 caused import issues in the add-on.

Description of changes

Replace imports with new ones.

Includes
  • Code changes
  • Tests
  • Documentation

@ajdapretnar
Copy link
Collaborator Author

@PrimozGodec I saw you already fixed something similar in ImageAnalytics. Could you perhaps check this one, too? I am mostly worried about the PubMed tests now using cache_dir() instead of buffer_dir, which might be backwards incompatible...

@PrimozGodec
Copy link
Collaborator

It looks good to me. cache_dir is present in Orange for a long time so I think it is safe to use it.
Before I merge it I will wait for #446 to see if I can fix the documentation test.

@PrimozGodec PrimozGodec mentioned this pull request Jul 2, 2019
3 tasks
@PrimozGodec PrimozGodec merged commit d2fab8a into biolab:master Jul 2, 2019
@PrimozGodec PrimozGodec mentioned this pull request Jul 9, 2019
3 tasks
@ajdapretnar ajdapretnar deleted the canvas-fix branch January 21, 2021 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants