Pickling UDPipe #387 #447
Merged
Pickling UDPipe #387 #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
==========================================
+ Coverage 85.9% 85.98% +0.08%
==========================================
Files 34 34
Lines 1937 1941 +4
Branches 331 331
==========================================
+ Hits 1664 1669 +5
+ Misses 233 232 -1
Partials 40 40 |
|
This no longer happens with the latest Network add-on master, but I am sure it doesn't hurt to have this handled since it avoid problems downstream. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Even though this will fix the issue with pickling
UDPipeLemmatizerthe fact thatCorpus.used_preprocessoris traveling around up toNetwork from Distancesis quite suspicious.Description of changes
updipe.Modelis not compatible with pickle protocol thus should be manually loaded.Includes