Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ufal.udpipe-temp #467

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Remove ufal.udpipe-temp #467

merged 1 commit into from
Nov 5, 2019

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented Nov 4, 2019

Issue

ufal.udpipe-temp is in requirements since it didn't compiled correctly at macos.

Description of changes

It seems it can be removed now since authors made a new release which adds missing compile requirements for macOS. I tested that on my macOS and it works correctly.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title Remove ufal.udpipe-temp [WIP] Remove ufal.udpipe-temp Nov 4, 2019
@codecov-io
Copy link

Codecov Report

Merging #467 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #467      +/-   ##
==========================================
- Coverage   85.88%   85.57%   -0.32%     
==========================================
  Files          34       34              
  Lines        1927     1927              
  Branches      329      329              
==========================================
- Hits         1655     1649       -6     
- Misses        232      238       +6     
  Partials       40       40

@PrimozGodec PrimozGodec changed the title [WIP] Remove ufal.udpipe-temp Remove ufal.udpipe-temp Nov 4, 2019
@PrimozGodec
Copy link
Collaborator Author

When we merge this I suggest making new release such that also this one can be merged: conda-forge/orange3-text-feedstock#29

@ajdapretnar ajdapretnar merged commit ed1a131 into master Nov 5, 2019
@PrimozGodec PrimozGodec deleted the ufal.udpipe-temp-remove branch November 5, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants