Topic Modeling: save selected topic as schema_only #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@VesnaT Please help with tests. I have tried all morning to come up with something sensible, but I can't figure out how to pass the selection around. |
ajdapretnar
changed the title
|
Check ajdapretnar#1 |
ajdapretnar
force-pushed
the
topic-settings
branch
from
336d570 to
ff6924d
Compare
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
=========================================
+ Coverage 85.6% 85.7% +0.09%
=========================================
Files 34 34
Lines 2001 2001
Branches 336 336
=========================================
+ Hits 1713 1715 +2
+ Misses 248 247 -1
+ Partials 40 39 -1 |
ajdapretnar
force-pushed
the
topic-settings
branch
from
ff6924d to
f0694fb
Compare
|
I fixed tests because assert_allclose could not be called on dtype object. And the two outputs had to be re-sorted due to gensim using 'quicksort' rather than 'mergesort'. Anyhow, test now pass locally, but Travis is still complaining the second output is None, despite the processEvent. 😩 I am throwing this widget out of the window the next change I get... |
ajdapretnar
force-pushed
the
topic-settings
branch
from
f0694fb to
039a1d5
Compare
ajdapretnar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #213.
Description of changes
Save a selection and load it upon reloading a workflow.
TODO: solve the issue of tests.Includes