[ENH] Word Cloud: Show bag of words weights when bag of words features available #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
changed the title
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
==========================================
+ Coverage 61.86% 61.93% +0.06%
==========================================
Files 59 59
Lines 6181 6197 +16
Branches 804 808 +4
==========================================
+ Hits 3824 3838 +14
- Misses 2221 2222 +1
- Partials 136 137 +1 |
|
Implements #401. |
ajdapretnar
reviewed
Dec 18, 2019
doc/widgets/wordcloud.md
Outdated
| @@ -11,9 +11,10 @@ Generates a word cloud from corpus. | |||
| **Outputs** | |||
|
|
|||
| - Corpus: Documents that match the selection. | |||
| - Word: Selected word that can be used as query in [Concordance](concordance.md). | |||
| - Selected Word: Selected word that can be used as query in [Concordance](concordance.md). | |||
| - Word Counts: Word together withe their weights. | |||
There was a problem hiding this comment.
Word together withe their weights. --> Words and their weights.
PrimozGodec
force-pushed
the
wordclod-bow
branch
from
c40af60 to
8f33243
Compare
PrimozGodec
force-pushed
the
wordclod-bow
branch
from
8f33243 to
d814f32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Bag-of-words weights should be shown in the Word Cloud widget. When TF-IDF is used bag-of-words weights should better highlight the importance of the word. It was also discussed at the last meeting.
Description of changes
With this PR bag-of-words, weights are used in the Word Cloud widget when available.
Includes