Include widgets in coverage #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #487 +/- ##
===========================================
- Coverage 85.77% 61.86% -23.91%
===========================================
Files 34 59 +25
Lines 1996 6181 +4185
Branches 333 804 +471
===========================================
+ Hits 1712 3824 +2112
- Misses 248 2221 +1973
- Partials 36 136 +100 |
|
I think the coverage slightly improved in these years and we should aim to improve it still. 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When I write a test for a widget I cannot access the coverage. I understand that the coverage for widgets was omitted since they are not well covered, but anyway it helps if one can access the coverage for widgets too.
Description of changes
With this PR I suggest including widgets in coverage. What do you think @ajdapretnar?
Includes