-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Word Enrichment: Computing in a separate thread (with ConcurrentMixin) #492
Conversation
16cd80c
to
1560eb7
Compare
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
=========================================
- Coverage 63.08% 62.48% -0.6%
=========================================
Files 59 59
Lines 6279 6243 -36
Branches 824 814 -10
=========================================
- Hits 3961 3901 -60
- Misses 2180 2208 +28
+ Partials 138 134 -4 |
3483ece
to
c5f8b21
Compare
This a great PR. But I wouldn't be me if I didn't have any comments. 😬 I am slightly confused by '18 words on the output'. The tooltip then explains that 18 words have been found, but do we have another widget that shows computational results instead of the output? I could be confusing for the users. On the same note: tree (i.e. found words) should not be selectable. It can confuse the user, too. |
Perhaps a solution for the status bar would be introducing a new icon that would replace the output icon (say a lightbulb) and signify the result of the widget. |
c5f8b21
to
e9fda89
Compare
I change texts and disabled the selection.
I will wait until we decide whether we implement this. |
e9fda89
to
58e36d5
Compare
It should be finished now. @ajdapretnar can you check when you have time. |
Issue
#221
Description of changes
Besides implementing the thread computation with ConcurrentWidgetMixin which fixes #221, this PR also:
Includes