-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bag of Words: add option to show bow features #499
Conversation
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 63.00% 63.02% +0.02%
==========================================
Files 59 59
Lines 6265 6293 +28
Branches 823 828 +5
==========================================
+ Hits 3947 3966 +19
- Misses 2180 2188 +8
- Partials 138 139 +1 |
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 63% 63.02% +0.02%
==========================================
Files 59 59
Lines 6265 6293 +28
Branches 823 828 +5
==========================================
+ Hits 3947 3966 +19
- Misses 2180 2188 +8
- Partials 138 139 +1 |
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 63.00% 63.02% +0.02%
==========================================
Files 59 59
Lines 6265 6293 +28
Branches 823 828 +5
==========================================
+ Hits 3947 3966 +19
- Misses 2180 2188 +8
- Partials 138 139 +1 |
901616c
to
5c72a9a
Compare
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 63% 63.67% +0.67%
==========================================
Files 59 59
Lines 6265 6296 +31
Branches 823 827 +4
==========================================
+ Hits 3947 4009 +62
+ Misses 2180 2152 -28
+ Partials 138 135 -3 |
I fixed the changing input.
|
self.assertFalse(all(f.attributes['hidden'] for f in | ||
self.get_output("Corpus").domain.attributes)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any
would fit better here -- in this case, it does not make difference but is more correct - just in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
5c72a9a
to
c02dad7
Compare
Codecov Report
@@ Coverage Diff @@
## master #499 +/- ##
==========================================
+ Coverage 63.00% 63.67% +0.67%
==========================================
Files 59 59
Lines 6265 6296 +31
Branches 823 827 +4
==========================================
+ Hits 3947 4009 +62
+ Misses 2180 2152 -28
+ Partials 138 135 -3 |
That is good now. Thanks. :) |
Issue
Fixes #498.
Description of changes
Add a checkbox to set 'hidden' attribute of attributes to True. Added to the base widget, so now both Bag of Words and SimHash use this option.
Includes