Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Word Cloud: Remove words with zero weights from word cloud #501

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented Feb 24, 2020

Issue

#500

Description of changes
  • Words with a bag of words below or equal zero are removed from the word cloud. Those are words that exist in the table but does not exist for the selected text.
  • Small optimization of extracting bow features
  • Test fix to be robust on computational error (instead of 2. number is 1.99999999999999999).
  • Rounding numbers in the list on the same number of decimal spaces (0 when all whole numbers, 2 when float numbers).
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-io
Copy link

Codecov Report

Merging #501 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
- Coverage    63.7%   63.67%   -0.03%     
==========================================
  Files          59       59              
  Lines        6296     6291       -5     
  Branches      827      826       -1     
==========================================
- Hits         4011     4006       -5     
  Misses       2151     2151              
  Partials      134      134

@nikicc
Copy link
Contributor

nikicc commented Feb 24, 2020

Codecov Report

Merging #501 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
- Coverage   63.70%   63.67%   -0.03%     
==========================================
  Files          59       59              
  Lines        6296     6291       -5     
  Branches      827      826       -1     
==========================================
- Hits         4011     4006       -5     
  Misses       2151     2151              
  Partials      134      134              

@codecov-io
Copy link

Codecov Report

Merging #501 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
- Coverage    63.7%   63.67%   -0.03%     
==========================================
  Files          59       59              
  Lines        6296     6291       -5     
  Branches      827      826       -1     
==========================================
- Hits         4011     4006       -5     
  Misses       2151     2151              
  Partials      134      134

@nikicc
Copy link
Contributor

nikicc commented Feb 24, 2020

Codecov Report

Merging #501 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage   63.70%   63.76%   +0.05%     
==========================================
  Files          59       59              
  Lines        6296     6306      +10     
  Branches      827      828       +1     
==========================================
+ Hits         4011     4021      +10     
  Misses       2151     2151              
  Partials      134      134              

@codecov-io
Copy link

Codecov Report

Merging #501 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage    63.7%   63.76%   +0.05%     
==========================================
  Files          59       59              
  Lines        6296     6306      +10     
  Branches      827      828       +1     
==========================================
+ Hits         4011     4021      +10     
  Misses       2151     2151              
  Partials      134      134

@nikicc
Copy link
Contributor

nikicc commented Feb 24, 2020

Codecov Report

Merging #501 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage   63.70%   63.76%   +0.05%     
==========================================
  Files          59       59              
  Lines        6296     6306      +10     
  Branches      827      828       +1     
==========================================
+ Hits         4011     4021      +10     
  Misses       2151     2151              
  Partials      134      134              

@PrimozGodec
Copy link
Collaborator Author

@ajdapretnar Rounding should be fixed now.

@codecov-io
Copy link

Codecov Report

Merging #501 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage    63.7%   63.76%   +0.05%     
==========================================
  Files          59       59              
  Lines        6296     6306      +10     
  Branches      827      828       +1     
==========================================
+ Hits         4011     4021      +10     
  Misses       2151     2151              
  Partials      134      134

@ajdapretnar ajdapretnar merged commit ecb7162 into biolab:master Feb 24, 2020
@PrimozGodec PrimozGodec deleted the word-cloud-no-zeros branch February 26, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants