Word Cloud: Run counting in new thread #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
wordcloud-thread
branch
from
2c928c8 to
44585cb
Compare
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 63.76% 63.84% +0.07%
==========================================
Files 59 59
Lines 6306 6322 +16
Branches 828 829 +1
==========================================
+ Hits 4021 4036 +15
Misses 2151 2151
- Partials 134 135 +1 |
PrimozGodec
force-pushed
the
wordcloud-thread
branch
from
44585cb to
4ffcbd5
Compare
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 63.76% 63.84% +0.07%
==========================================
Files 59 59
Lines 6306 6322 +16
Branches 828 829 +1
==========================================
+ Hits 4021 4036 +15
Misses 2151 2151
- Partials 134 135 +1 |
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 63.76% 63.84% +0.07%
==========================================
Files 59 59
Lines 6306 6322 +16
Branches 828 829 +1
==========================================
+ Hits 4021 4036 +15
Misses 2151 2151
- Partials 134 135 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When selecting documents in the data table, the Word Cloud widget was blocking main thread -- user could not smoothly select documents.
Description of changes
When several longer documents the counting of words can take up to a few seconds. The counting is now moved to the separate thread - with concurrent mixin.
Includes