[ENH] List files that are not loaded #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
changed the title
Codecov Report
@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 68.72% 73.69% +4.97%
==========================================
Files 66 66
Lines 7443 7462 +19
Branches 996 999 +3
==========================================
+ Hits 5115 5499 +384
+ Misses 2157 1751 -406
- Partials 171 212 +41 |
PrimozGodec
changed the title
PrimozGodec
force-pushed
the
list-nor-read
branch
from
c0ce6fd to
413e4f2
Compare
PrimozGodec
changed the title
|
Thanks for working on this! I had something else in mind. And additional output that would list the unread files in a data table. Do you think that would be an overkill? I just think there are several files with long names, a tooltip could get useless quite fast. With a data table, one can even save the output for reference. I dunno. Perhaps this is redundant. What do you think? |
PrimozGodec
force-pushed
the
list-nor-read
branch
from
413e4f2 to
49d24f1
Compare
|
I think it is a better solution. I added the output with skipped documents. |
|
I can't believe Import Documents had no tests before. 😱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #551
Description of changes
Includes