[ENH] Corpus Viewer: Output selected data and memorize selection #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
changed the title
|
Thanks for the PR! I have to say I am not a fan of not seeing anything upon opening the widget. Orange doesn't normally work that it - it has a smart default. Filtering also sometimes produces strange results. I mean the highlight doesn't match the filter on first view. If I select something or click anywhere else, the view gets updated and it is correct. |
PrimozGodec
force-pushed
the
corpus-viewer-output-sel
branch
2 times, most recently
from
e207135 to
bab643e
Compare
Codecov Report
@@ Coverage Diff @@
## master #562 +/- ##
==========================================
+ Coverage 68.72% 73.88% +5.16%
==========================================
Files 66 66
Lines 7443 7474 +31
Branches 996 1000 +4
==========================================
+ Hits 5115 5522 +407
+ Misses 2157 1749 -408
- Partials 171 203 +32 |
PrimozGodec
force-pushed
the
corpus-viewer-output-sel
branch
from
bab643e to
feb8e8b
Compare
PrimozGodec
force-pushed
the
corpus-viewer-output-sel
branch
from
feb8e8b to
6f1c480
Compare
PrimozGodec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #507
Description of changes
Includes