[ENH] Document embedders: additional languages #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 73.69% 73.91% +0.22%
==========================================
Files 66 66
Lines 7462 7568 +106
Branches 999 1000 +1
==========================================
+ Hits 5499 5594 +95
- Misses 1751 1763 +12
+ Partials 212 211 -1 |
|
I tested all embedders and it seems they work. |
|
We have English as a default in most places. Probably it should be here as well? (I know, we are forcing the lingua franca, but even Orange comes in English only) |
|
The rest works well, btw. |
PrimozGodec
force-pushed
the
document-embedding-languages
branch
from
aa8fc26 to
e754876
Compare
|
Uf completely forgot about that. English should be default now. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Document embedders currently support only three languages.
Description of changes
With this PR we add support for 28 additional languages.
Includes