[FIX] Import documents: normalize imported text and file names #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
=======================================
Coverage 73.80% 73.81%
=======================================
Files 66 66
Lines 7464 7465 +1
Branches 1000 1000
=======================================
+ Hits 5509 5510 +1
Misses 1744 1744
Partials 211 211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Filename (and potentially text too) can contain characters that are written in decompose form (č is composed as a char c and separate caron). It causes problems when we filter documents (user inputs č as precomposed Unicode char).
Description of changes
With this PR text is normalized (all decomposed chars are changed to precomposed) before outputted from the widget
Includes