[FIX] Corpus - extend attributes: Fix error with renamed text feature #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #574 +/- ##
==========================================
+ Coverage 70.86% 73.90% +3.03%
==========================================
Files 66 66
Lines 7565 7575 +10
Branches 999 1002 +3
==========================================
+ Hits 5361 5598 +237
+ Misses 2011 1767 -244
- Partials 193 210 +17 |
PrimozGodec
force-pushed
the
fix-feature-not-found
branch
from
fa6f03f to
b9f6674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When in extednd_attributes function one of the text features is renamed extending fails with ValueError.
Description of changes
Changed
set_text_featuresfunction to handle cases with renamed features (when the feature has Identity incompute_values).Includes