Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Corpus - from_table: keep text feature when renamed #585

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

PrimozGodec
Copy link
Collaborator

Issue

Fixes #581

Description of changes

Identify and keep renamed text_feature

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec force-pushed the fix-corpus-from-table branch from 6dc6c7d to 1591cee Compare October 9, 2020 10:12
@codecov-io
Copy link

codecov-io commented Oct 9, 2020

Codecov Report

Merging #585 into master will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #585      +/-   ##
==========================================
+ Coverage   74.04%   74.31%   +0.26%     
==========================================
  Files          66       66              
  Lines        7590     7591       +1     
  Branches     1004     1006       +2     
==========================================
+ Hits         5620     5641      +21     
+ Misses       1767     1748      -19     
+ Partials      203      202       -1     

@PrimozGodec PrimozGodec force-pushed the fix-corpus-from-table branch from 1591cee to 2060c7b Compare October 9, 2020 11:23
@ajdapretnar ajdapretnar merged commit 63bb2f2 into biolab:master Oct 9, 2020
@PrimozGodec PrimozGodec deleted the fix-corpus-from-table branch March 29, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corpus: handle renaming of a text feature
3 participants