Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Preprocess: Filter by absolute frequency #601

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Nov 24, 2020

Issue

Fixes #597

Description of changes

Add a radio button to distinguish between relative and absolute frequency option.

Includes
  • Code changes
  • Tests
  • Documentation

@ajdapretnar
Copy link
Collaborator

ajdapretnar commented Nov 26, 2020

I like this option and it works well, but the tests are failing with settings migration. I think the test just needs to be updated.

@VesnaT VesnaT force-pushed the preprocess_doc_freq branch from 568436b to 7020722 Compare November 27, 2020 06:07
@codecov-io
Copy link

codecov-io commented Nov 27, 2020

Codecov Report

Merging #601 (6e9aad7) into master (c894c72) will increase coverage by 3.16%.
The diff coverage is 78.49%.

@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   71.03%   74.20%   +3.16%     
==========================================
  Files          66       66              
  Lines        7638     7780     +142     
  Branches     1017     1036      +19     
==========================================
+ Hits         5426     5773     +347     
+ Misses       2023     1799     -224     
- Partials      189      208      +19     

@ajdapretnar
Copy link
Collaborator

One thing I have noticed with this. I might be nitpicking, but it could be important. If I select Absolute frequency, then change the parameters in Relative (without selecting Relative!), preprocessing is run once again. I don't think it is necessary. Is there a simple fix for this?

@VesnaT VesnaT force-pushed the preprocess_doc_freq branch from 7020722 to 6e9aad7 Compare November 28, 2020 06:29
@VesnaT
Copy link
Contributor Author

VesnaT commented Dec 3, 2020

One thing I have noticed with this. I might be nitpicking, but it could be important. If I select Absolute frequency, then change the parameters in Relative (without selecting Relative!), preprocessing is run once again. I don't think it is necessary. Is there a simple fix for this?

This has been fixed.

@ajdapretnar ajdapretnar merged commit b702402 into biolab:master Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preprocess Text: document frequency no longer supports integers
3 participants