Concordance - search in the separate thread #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works well, but the tests are failing. They do not seem related to this commit, but it would still be nice if tests pass. |
PrimozGodec
force-pushed
the
concordance-thread
branch
from
6a330c9 to
8b4e885
Compare
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
==========================================
+ Coverage 73.93% 74.06% +0.13%
==========================================
Files 72 72
Lines 9122 9134 +12
Branches 1234 1236 +2
==========================================
+ Hits 6744 6765 +21
+ Misses 2143 2133 -10
- Partials 235 236 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #660
Description of changes
Now searching for concordance, which is the operation that blocks the main thread, is performed in the separate thread with ConcurentMixin.
Includes