LDA: Add random state #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
==========================================
+ Coverage 74.02% 74.09% +0.06%
==========================================
Files 72 72
Lines 9159 9230 +71
Branches 1239 1253 +14
==========================================
+ Hits 6780 6839 +59
- Misses 2139 2149 +10
- Partials 240 242 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
LDA is a generative model and has thus a random state that one can preset. For Orange workflows to be reproducible, we need to set a fixed random seed.
Description of changes
Add a fixed random seed.
Should we instead add a checkbox for reproducible LDA in the widget?
Includes