normalize: speedup preprocessing with caching #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
preprocess-speedup
branch
from
39c7b26 to
5daa2e8
Compare
PrimozGodec
changed the title
PrimozGodec
force-pushed
the
preprocess-speedup
branch
from
5daa2e8 to
862168a
Compare
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
==========================================
- Coverage 74.01% 74.00% -0.01%
==========================================
Files 72 72
Lines 9477 9484 +7
Branches 1291 1292 +1
==========================================
+ Hits 7014 7019 +5
- Misses 2218 2219 +1
- Partials 245 246 +1 |
PrimozGodec
force-pushed
the
preprocess-speedup
branch
from
862168a to
f409a6d
Compare
ajdapretnar
reviewed
Aug 19, 2021
| @@ -1,3 +1,4 @@ | |||
| from functools import lru_cache | |||
There was a problem hiding this comment.
I forgot to remove it after I change my implementation. It is now removed. Thanks
PrimozGodec
force-pushed
the
preprocess-speedup
branch
2 times, most recently
from
e5e35d1 to
4feabd1
Compare
PrimozGodec
force-pushed
the
preprocess-speedup
branch
from
4feabd1 to
cedb7d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Normalisation is the slowest process in preprocessing (especially UDPIPE).
Description of changes
Speedups:
Udpipe:
WordNet:
Porter:
Snowball:
* on 20 newsgroups dataset
Includes