UDPipe Lemmatizer: remove self.model from pickle #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
==========================================
- Coverage 74.20% 74.17% -0.03%
==========================================
Files 72 72
Lines 9576 9577 +1
Branches 1303 1303
==========================================
- Hits 7106 7104 -2
- Misses 2221 2223 +2
- Partials 249 250 +1 |
PrimozGodec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
UDPipe remembers models' absolute files on computer via instance of UDPipeModels class which cause that normalisation with the same model on the other computer fails.
Description of changes
This PR removes UDPipeModels's instance from the pickle (and init it on unpickle). It can be without harm initialize on unpickling and we even save the amount of the pickle content.
The test is not required since existing tests already test pickling/unpickling.
Includes