Store ngrams_corpus correctly #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajdapretnar
force-pushed
the
pass-ngrams
branch
from
2fae313 to
3dce948
Compare
Codecov Report
@@ Coverage Diff @@
## master #729 +/- ##
==========================================
- Coverage 74.19% 74.17% -0.02%
==========================================
Files 72 72
Lines 9572 9584 +12
Branches 1302 1304 +2
==========================================
+ Hits 7102 7109 +7
- Misses 2222 2227 +5
Partials 248 248 |
PrimozGodec
force-pushed
the
pass-ngrams
branch
2 times, most recently
from
9ce736d to
6617c2c
Compare
PrimozGodec
force-pushed
the
pass-ngrams
branch
from
6617c2c to
39576a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Bag of words didn't store results correctly to
Corpus.ngrams_corpus.Description of changes
Store
ngrams_corpuswhen transforming or copying the corpus.Now, Topic Modelling accepts pre-existing bag of words matrix. 🎉
Includes