Corpus Viewer: Run search when finished typing the query (on enter). #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
1 similar comment
|
/rebase |
|
@lanzagar can you rebase on master? We cannot use /rebase yet since rebase includes workflows files. It will work on PRs from the current master. |
lanzagar
force-pushed
the
corpview_search
branch
from
faba3b1 to
2937b14
Compare
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
=======================================
Coverage 74.35% 74.35%
=======================================
Files 73 73
Lines 9669 9668 -1
Branches 1320 1320
=======================================
Hits 7189 7189
+ Misses 2227 2224 -3
- Partials 253 255 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #704 using Option 1.
Description of changes
Do not run search after every keypress (slow), but only once after typing the whole query and pressing Enter.
Includes