Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] score-documents: handle document titles with newlines #754

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

PrimozGodec
Copy link
Collaborator

Issue

In score documents, titles with newline characters were cropped and centered vertically

Screenshot 2021-11-19 at 15 44 50

Description of changes

Remove newline characters from titles for display purpose (as table widget and corpus viewer do)

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title score-documents: handle document titles with newlines [FIX] score-documents: handle document titles with newlines Nov 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #754 (eff53ba) into master (da42f78) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   74.46%   74.50%   +0.03%     
==========================================
  Files          74       74              
  Lines        9911     9918       +7     
  Branches     1336     1338       +2     
==========================================
+ Hits         7380     7389       +9     
+ Misses       2273     2272       -1     
+ Partials      258      257       -1     

@VesnaT VesnaT merged commit 4d67b95 into biolab:master Nov 25, 2021
@PrimozGodec PrimozGodec deleted the score-documents-title branch March 29, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants