-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OWCollocations: widget for observing collocations #782
Conversation
This is now ready for a review and comments.
|
Adding colored bars could be done by adding If I understand what this widget does correctly, I imagine you could end up with quite a few rows here for larger datasets so running the computation concurrently makes sense. Also with radio buttons you can only view one set of scores at a time. |
Most likely. I'd leave concurrent implementation to masters. :)
This is intentional. The top words can vary significantly. I thought it makes more sense to view a single score at a time. Otherwise you'd have extremely long tables with many nans. |
Also, thanks for the hints regarding the colored bars! |
7c8424d
to
29eeb5c
Compare
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
==========================================
+ Coverage 76.80% 76.84% +0.03%
==========================================
Files 84 85 +1
Lines 11957 12038 +81
Branches 1881 1886 +5
==========================================
+ Hits 9184 9250 +66
- Misses 2464 2476 +12
- Partials 309 312 +3 |
29eeb5c
to
3290db0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks perfect. I just added a few minor comments.
3290db0
to
3ee3b17
Compare
@PrimozGodec As discussed, I've copied the code from Rank for now. Will submit another PR with changes from the master, which can be merged after we release Text and once Orange is released, too. Other suggestions are also implemented. |
If you really mean to someday remove the code from rank, you need to add a time bomb, that is, a test that will fail when Orange version is above XX, with a message to remove the code and this test. |
You are absolutely right. I've added the test, hope it's ok. |
78133ff
to
37e95c2
Compare
37e95c2
to
9cbaa4e
Compare
Nicely done. :) |
Issue
No widget for showing collocations.
Description of changes
OWCollocations widget.
Includes