Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Semantic Viewer: Put NaNs last when sorting #800

Merged
merged 1 commit into from
Mar 23, 2022
Merged

[FIX] Semantic Viewer: Put NaNs last when sorting #800

merged 1 commit into from
Mar 23, 2022

Conversation

VesnaT
Copy link
Contributor

@VesnaT VesnaT commented Mar 23, 2022

Issue

Fixes #796

Includes
  • Code changes
  • Tests
  • Documentation

@VesnaT VesnaT force-pushed the semantic_viewer_sort branch from 291a207 to bc0db04 Compare March 23, 2022 07:26
@VesnaT VesnaT force-pushed the semantic_viewer_sort branch from bc0db04 to 7c87ae6 Compare March 23, 2022 07:44
@ajdapretnar
Copy link
Collaborator

This works well for me. Do I just ignore the tests?

@VesnaT
Copy link
Contributor Author

VesnaT commented Mar 23, 2022

This works well for me. Do I just ignore the tests?

I guess.

@PrimozGodec
Copy link
Collaborator

PrimozGodec commented Mar 23, 2022 •
edited
Loading

I think it would solve filing windows tests #802. If you want to test on Windows too you can now rebase or just merge this one in the master

@ajdapretnar ajdapretnar merged commit 74afffc into biolab:master Mar 23, 2022
@PrimozGodec PrimozGodec mentioned this pull request Mar 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Semantic Viewer: put nans at the bottom when sorting
3 participants
@VesnaT @ajdapretnar @PrimozGodec