[ENH] Document Embedding: add SBERT #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #839 +/- ##
==========================================
+ Coverage 76.92% 76.96% +0.03%
==========================================
Files 85 85
Lines 11966 11950 -16
Branches 1880 1877 -3
==========================================
- Hits 9205 9197 -8
+ Misses 2454 2449 -5
+ Partials 307 304 -3 |
PrimozGodec
reviewed
May 9, 2022
There was a problem hiding this comment.
Thank you for implementing it looks good. I just dropped a few minor comments.
Please also rebase this PR to master (sorry I was changing callbacks already since I didn't notice that you have been changing that here).
Before it can get merged we need to add GPU sbert embedders to the server. Hope it will be done soon. :)
djukicn
force-pushed
the
document-embedding-add-sbert
branch
2 times, most recently
from
402e42c to
76457e2
Compare
PrimozGodec
force-pushed
the
document-embedding-add-sbert
branch
from
76457e2 to
b67016c
Compare
PrimozGodec
force-pushed
the
document-embedding-add-sbert
branch
from
b67016c to
9df9fff
Compare
PrimozGodec
force-pushed
the
document-embedding-add-sbert
branch
from
9df9fff to
170cd4c
Compare
PrimozGodec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Implements #639.
Description of changes
Added multilingual SBERT into Document Embedding widget.
Includes