Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Update embedder callbacks #842

Merged
merged 5 commits into from
May 4, 2022

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented May 3, 2022

Issue

Embedder module in core Orange changed callbacks to callbacks which report percentage instead of success.

Extra: Gensim has a new release and so one of the tests in topic modelling started to fail to remind us to set the random seed for lsi.

Description of changes
  • Updates callbacks in document embedding
  • Update callbacks in semantic search
  • Setting the random seed for LSI
  • Fix some other deprecations found in the module
Includes
  • Code changes
  • Tests
  • Documentation

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2022

Codecov Report

Merging #842 (ecf4f9c) into master (7edc6ee) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
- Coverage   76.04%   76.03%   -0.01%     
==========================================
  Files          79       79              
  Lines       11163    11143      -20     
  Branches     1761     1757       -4     
==========================================
- Hits         8489     8473      -16     
  Misses       2396     2396              
+ Partials      278      274       -4     

@PrimozGodec PrimozGodec merged commit 7123f33 into biolab:master May 4, 2022
@PrimozGodec PrimozGodec deleted the update-callbacks branch May 4, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants