Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Create corpus - new widget #854

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented May 30, 2022

Issue

Sometimes it would be handy to create corpus with just pasting few documents

Description of changes

Create a corpus widget that enables create a simple corpus by pasting or typing documents directly in Orange

Todo
  • Support removing documents
  • tests
  • few details marked with todo in the widget
Includes
  • Code changes
  • Tests
  • Documentation - will be added when we agree that a widget is in the right shape

@PrimozGodec PrimozGodec marked this pull request as draft May 30, 2022 14:26
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2022

Codecov Report

Merging #854 (bb6bd21) into master (4c38b3f) will increase coverage by 0.16%.
The diff coverage is 98.05%.

❗ Current head bb6bd21 differs from pull request most recent head 32c1629. Consider uploading reports for the commit 32c1629 to get more accurate results

@@            Coverage Diff             @@
##           master     #854      +/-   ##
==========================================
+ Coverage   76.67%   76.84%   +0.16%     
==========================================
  Files          83       84       +1     
  Lines       11761    11873     +112     
  Branches     1867     1875       +8     
==========================================
+ Hits         9018     9124     +106     
- Misses       2439     2444       +5     
- Partials      304      305       +1     

@PrimozGodec PrimozGodec marked this pull request as ready for review May 31, 2022 11:22
@PrimozGodec PrimozGodec changed the title Create corpus - new widget [ENH] Create corpus - new widget May 31, 2022
@ajdapretnar
Copy link
Collaborator

The widget looks good. I would perhaps make the initial boxes even shorter (less tall), but I don't object to the current situation.

@PrimozGodec PrimozGodec force-pushed the create-corpus branch 2 times, most recently from bb6bd21 to 32c1629 Compare June 2, 2022 09:33
@PrimozGodec
Copy link
Collaborator Author

The widget looks good. I would perhaps make the initial boxes even shorter (less tall), but I don't object to the current situation.

I just changed the default to 3 documents. Now boxes are a bit shorter by default

@ajdapretnar
Copy link
Collaborator

@PrimozGodec I approve the widget. I added the documentation, too.

@PrimozGodec
Copy link
Collaborator Author

@ajdapretnar thanks a lot for help with the documentation. :)

@PrimozGodec PrimozGodec merged commit d9ac818 into biolab:master Jun 3, 2022
@PrimozGodec PrimozGodec deleted the create-corpus branch June 3, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants