[FIX] Word cloud - add type to the selected words output #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
changed the title
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
+ Coverage 76.84% 76.92% +0.08%
==========================================
Files 85 85
Lines 11965 11966 +1
Branches 1880 1880
==========================================
+ Hits 9194 9205 +11
+ Misses 2464 2454 -10
Partials 307 307 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Word cloud's Selected Words output is missing a type in a word column, and it is not compatible with Semantic Viewer and some other Widgets.
Description of changes
Add type annotation and tests
Includes