Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Corpus: fix ngrams_corpus #871

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

djukicn
Copy link
Collaborator

@djukicn djukicn commented Jun 24, 2022

Issue

Fixes #809.

Description of changes
Includes
  • Code changes
  • Tests
  • Documentation

orangecontrib/text/corpus.py Show resolved Hide resolved
orangecontrib/text/topics/topics.py Outdated Show resolved Hide resolved
orangecontrib/text/topics/topics.py Outdated Show resolved Hide resolved
orangecontrib/text/topics/topics.py Outdated Show resolved Hide resolved
orangecontrib/text/vectorization/base.py Show resolved Hide resolved
orangecontrib/text/topics/topics.py Outdated Show resolved Hide resolved
@djukicn djukicn force-pushed the fix-topic-modelling branch from 2f0b109 to f90aefe Compare June 28, 2022 07:56
@PrimozGodec PrimozGodec changed the title Corpus: fix ngrams_corpus [FIX] Corpus: fix ngrams_corpus Jun 30, 2022
@djukicn djukicn force-pushed the fix-topic-modelling branch from f90aefe to 944199a Compare July 8, 2022 08:09
@djukicn djukicn force-pushed the fix-topic-modelling branch from 944199a to 4c33e45 Compare July 8, 2022 08:28
@codecov-commenter
Copy link

Codecov Report

Merging #871 (944199a) into master (7f3baed) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 944199a differs from pull request most recent head 4c33e45. Consider uploading reports for the commit 4c33e45 to get more accurate results

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
+ Coverage   76.92%   76.93%   +0.01%     
==========================================
  Files          85       85              
  Lines       11966    11955      -11     
  Branches     1880     1883       +3     
==========================================
- Hits         9205     9198       -7     
+ Misses       2454     2451       -3     
+ Partials      307      306       -1     

@ajdapretnar
Copy link
Collaborator

I can confirm this resolves the issue and the results remain the same as before.

@ajdapretnar ajdapretnar merged commit 3243b21 into biolab:master Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topic Modeling: fails on sampled input
4 participants