[FIX] Replace exec_ with exec and fix deprecations #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #887 +/- ##
==========================================
+ Coverage 76.91% 76.92% +0.01%
==========================================
Files 85 85
Lines 11984 11984
Branches 1883 1883
==========================================
+ Hits 9217 9219 +2
+ Misses 2460 2459 -1
+ Partials 307 306 -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
exec_for opening dialogues as of PyQt5 already,execis available.addSpacekeyword is deprecated and, in my opinion, not needed (the user interface already looks good with normal spacing)Description of changes
exec_withexec.addSpacein several widgets. It can be replaced by a separator, but in my opinion, it is not necessary.Includes