[FIX] VectorizationComputeValue - fix unpickling old pickles #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
fix-vectorization-cv
branch
from
ccd7628 to
0f29b13
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #904 +/- ##
=======================================
Coverage 76.94% 76.95%
=======================================
Files 86 86
Lines 12149 12152 +3
Branches 1904 1904
=======================================
+ Hits 9348 9351 +3
Misses 2485 2485
Partials 316 316 |
|
/rebase |
biolab-helper
force-pushed
the
fix-vectorization-cv
branch
from
0f29b13 to
6fbbb81
Compare
PrimozGodec
force-pushed
the
fix-vectorization-cv
branch
from
6fbbb81 to
8e2789d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Before the orange3-text version, the 1.12.0 VectorizationComputeValue's variable was wrongly set to a current
variable (a variable that has this compute value attached) instead of
the original variable, which caused failure after the latest changes in core
Orange. It was fixed in #900.
Anyway, it is still set in pickles created before 1.12.0.
Description of changes
Remove the variable when unpickling VectorizationComputeValue.
Includes