Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Score Documents - cast bool scores to float #913

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

PrimozGodec
Copy link
Collaborator

Issue

In some rare cases in cases of words appearance, scores were boolean instead of numeric values (when aggregation result was inside the bool range -- for example, when using min aggregation). It caused the widget to crash when plotting range bars.

Description of changes

Cast word appearance scores to float before aggregating.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec requested a review from VesnaT October 20, 2022 14:38
@VesnaT VesnaT self-assigned this Oct 20, 2022
@VesnaT VesnaT merged commit 6b2796a into biolab:master Oct 21, 2022
@PrimozGodec PrimozGodec deleted the fix-scoredoc branch March 29, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants