Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add language to corpus #916

Merged
merged 4 commits into from
Nov 7, 2022
Merged

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented Nov 4, 2022

Issue

Implements the new approach to language detection in the add-on.

Description of changes

This is the first of a series of PRs connected to moving language setting to the corpus:

  • The function for language detection and dict of supported languages (all languages supported by any method in Addon)
  • Removing the old language_codes script, which is now replaced with the language module
  • Adoption of corpus to store language setting. Corpus can have the language set to the iso code of the language or None
  • Setting language attributes to repository datasets
  • Implementing language detection and dropdown in Corpus viewer
  • Temporarily copy attributes until it is fixed and released in Orange [FIX] Table - copy attributes when creating table from table orange3#6189
Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec marked this pull request as draft November 4, 2022 07:27
@PrimozGodec PrimozGodec force-pushed the language-owcorpus branch 3 times, most recently from 5b2ee48 to da9d859 Compare November 4, 2022 09:19
@codecov-commenter
Copy link

Codecov Report

Merging #916 (9914fa7) into master (502eaf7) will increase coverage by 0.07%.
The diff coverage is 88.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
+ Coverage   77.18%   77.25%   +0.07%     
==========================================
  Files          86       86              
  Lines       12043    12113      +70     
  Branches     1578     1586       +8     
==========================================
+ Hits         9295     9358      +63     
- Misses       2447     2452       +5     
- Partials      301      303       +2     

@PrimozGodec PrimozGodec force-pushed the language-owcorpus branch 2 times, most recently from 099f634 to a2c4def Compare November 4, 2022 10:23
@PrimozGodec PrimozGodec marked this pull request as ready for review November 4, 2022 10:31
@PrimozGodec
Copy link
Collaborator Author

It should be ready now. I also considered all comments from #874

@PrimozGodec PrimozGodec changed the title [ENH] Language to corpus [ENH] Add language to corpus Nov 4, 2022
@VesnaT VesnaT merged commit 5c55009 into biolab:master Nov 7, 2022
@PrimozGodec PrimozGodec deleted the language-owcorpus branch March 29, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants