Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Twitter - add language to corpus #921

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented Nov 25, 2022

Description of changes

Adding language to the corpus

Twitter widget use language set by the user; if language is not set and all tweets have the same language, it is set as Corpus'es language. When tweets are in different languages, the language is set to None.

I also changed the Twitter widget so that variables are initialized when Corpus is built. Before, the same variable instance was used multiple times, and those settings were shared (values, ....).

Also removing redundant enumerations.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec force-pushed the langdetect-twitter branch 2 times, most recently from 92d60f5 to 6a67439 Compare November 25, 2022 14:16
@PrimozGodec
Copy link
Collaborator Author

/rebase

@codecov-commenter
Copy link

Codecov Report

Merging #921 (10d61f0) into master (f9579dd) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #921      +/-   ##
==========================================
+ Coverage   77.23%   77.27%   +0.04%     
==========================================
  Files          86       86              
  Lines       12119    12119              
  Branches     1587     1586       -1     
==========================================
+ Hits         9360     9365       +5     
+ Misses       2454     2451       -3     
+ Partials      305      303       -2     

@PrimozGodec PrimozGodec requested a review from VesnaT December 2, 2022 08:52
@PrimozGodec PrimozGodec assigned PrimozGodec and VesnaT and unassigned PrimozGodec Dec 2, 2022
@VesnaT VesnaT merged commit 1c34a5d into biolab:master Dec 12, 2022
@PrimozGodec PrimozGodec deleted the langdetect-twitter branch January 11, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants