[ENH] NYTimes - add language to corpus #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
lagdetect-nyt
branch
from
6495309 to
9c74a63
Compare
PrimozGodec
force-pushed
the
lagdetect-nyt
branch
from
9c74a63 to
f81c1dc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #926 +/- ##
==========================================
- Coverage 77.81% 77.53% -0.28%
==========================================
Files 87 86 -1
Lines 12321 12261 -60
Branches 1620 1608 -12
==========================================
- Hits 9587 9507 -80
- Misses 2434 2455 +21
+ Partials 300 299 -1 |
PrimozGodec
force-pushed
the
lagdetect-nyt
branch
2 times, most recently
from
76f8e6c to
f70dee8
Compare
PrimozGodec
force-pushed
the
lagdetect-nyt
branch
from
f70dee8 to
3327bb4
Compare
PrimozGodec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from #874
Description of changes
Set language to the corpus. For NY Times, it is always English.
In the current implementation, Corpus variables are created when NYT is initialized, so they are shared between multiple corpora. The problem appears when different values are added to DiscreteVariable by different calls, so values accumulate. This PR changes that variables are defined in each call separately.
Includes