[ENH] Score Documents - enable matching n-grams #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
create-corpus-fix-tests
branch
from
c8ecdf8 to
a873fe0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #935 +/- ##
=======================================
Coverage 77.62% 77.62%
=======================================
Files 86 86
Lines 12291 12291
Branches 1609 1608 -1
=======================================
Hits 9541 9541
Misses 2452 2452
Partials 298 298 |
PrimozGodec
force-pushed
the
create-corpus-fix-tests
branch
from
a873fe0 to
84873b7
Compare
PrimozGodec
force-pushed
the
create-corpus-fix-tests
branch
from
84873b7 to
784eebf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently Score Document matches only words from the input. When more-term words are on input, it fails with scoring (only score with first word from the term).
Description of changes
With this modifications Corpus's preprocessing defines how words are preprocessed and matched. E.g. if the user selects to use bi-grams (only) on the corpus, terms (from words input) are matched as bigrams. In this case terms that are words are ignored, and those that are longer than bigrams are transformed to bigrams.
Includes