Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Document embedding - Use language from the corpus #953

Merged
merged 2 commits into from
Apr 7, 2023

Conversation

PrimozGodec
Copy link
Collaborator

Derived from #874

Description of changes

Use language from Corpus in the Document embedding widget

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec changed the title Document embedding - Use language from the corpus [ENH] Document embedding - Use language from the corpus Mar 10, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2023

Codecov Report

Merging #953 (688ff75) into master (9bd6012) will increase coverage by 0.05%.
The diff coverage is 93.54%.

❗ Current head 688ff75 differs from pull request most recent head 90fc0a5. Consider uploading reports for the commit 90fc0a5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
+ Coverage   77.79%   77.85%   +0.05%     
==========================================
  Files          87       87              
  Lines       12302    12330      +28     
  Branches     1613     1622       +9     
==========================================
+ Hits         9570     9599      +29     
+ Misses       2433     2432       -1     
  Partials      299      299              

@PrimozGodec PrimozGodec force-pushed the language-document-embeddings branch from 6f2b72d to 688ff75 Compare March 29, 2023 09:50
@PrimozGodec
Copy link
Collaborator Author

 @VesnaT, this one is now fixed in a way that it uses the language from Corpus but still keeps the language setting dropdown.

@PrimozGodec PrimozGodec force-pushed the language-document-embeddings branch from 688ff75 to 90fc0a5 Compare March 29, 2023 10:22
@VesnaT VesnaT merged commit ac3aeb9 into biolab:master Apr 7, 2023
@PrimozGodec PrimozGodec deleted the language-document-embeddings branch April 11, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants